Use PySide6 instead of PySide2 in CI testing #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corranwebster
approved these changes
Aug 8, 2022
mdickinson
added a commit
that referenced
this pull request
Aug 9, 2022
This PR changes the .[test] setup.py requirements to use PySide6 instead of PySide2 for Python3.8 and later, and removes the version constraint on the PySide install. We exclude Python 3.11, since the PySide6 eggs available on PyPI claim not to work on 3.11. While we're here, we also clean up an outdated Sphinx version restriction. (cherry picked from commit e0c6008)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
.[test]requirements to use PySide6 instead of PySide2, and removes the version constraint on the PySide install.EDIT: Updated to use PySide2 for Python 3.6 and 3.7, and PySide6 for Python >= 3.8. Currently, the PyPI eggs for PySide6 claim only to work for Python < 3.11, so we add that restriction as well.
While we're here, we also clean up an outdated Sphinx version restriction.