Fix some ETSConfig and test nits #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corranwebster
approved these changes
Aug 9, 2022
mdickinson
added a commit
that referenced
this pull request
Aug 9, 2022
) Fix some nits noticed during reviewing #1670. (But sufficiently unrelated to #1670 that I couldn't justify squeezing them into that PR.) * Fix weird docstring end-quote indentations * Fix overriding of TestCase.run, which implicitly assumes that we'll be using unittest as our test runner. * Fix another test that assumed that the test runner would be unittest. (cherry picked from commit febdd99)
mdickinson
added a commit
that referenced
this pull request
Aug 9, 2022
This PR adds a pytest configuration to ignore traits-stubs when running the Traits tests. (It's fine to run the traits-stubs tests under pytest, but it needs to be done from the traits-stubs directory as a separate test run.) Together with #1684 and #1683, this closes #1288. (cherry picked from commit 18341f7)
mdickinson
added a commit
that referenced
this pull request
Aug 9, 2022
) Fix some nits noticed during reviewing #1670. (But sufficiently unrelated to #1670 that I couldn't justify squeezing them into that PR.) * Fix weird docstring end-quote indentations * Fix overriding of TestCase.run, which implicitly assumes that we'll be using unittest as our test runner. * Fix another test that assumed that the test runner would be unittest. (cherry picked from commit febdd99)
mdickinson
added a commit
that referenced
this pull request
Aug 9, 2022
This PR adds a pytest configuration to ignore traits-stubs when running the Traits tests. (It's fine to run the traits-stubs tests under pytest, but it needs to be done from the traits-stubs directory as a separate test run.) Together with #1684 and #1683, this closes #1288. (cherry picked from commit 18341f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some nits noticed during reviewing #1670. (But sufficiently unrelated to #1670 that I couldn't justify squeezing them into that PR.)
TestCase.run, which implicitly assumes that we'll be usingunittestas our test runner.