Remove outdated alias #1681
Merged
Remove outdated alias #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes an `enumerate = enumerate` assignment that should no longer be necessary. Technically, this is a backwards incompatible change: anyone who imports `enumerate` from `traits.trait_base` will no longer be able to do so. However, the workaround is immediate (just delete that import so that you pick up the built-in `enumerate`), and code that's doing this is already wrong on so many levels, so I don't feel bad about making this change without a deprecation period.
itziakos
approved these changes
Aug 4, 2022
mdickinson
added a commit
that referenced
this pull request
Aug 9, 2022
This PR removes an `enumerate = enumerate` assignment that should no longer be necessary. Technically, this is a backwards incompatible change: anyone who imports `enumerate` from `traits.trait_base` will no longer be able to do so. However, the workaround is immediate (just delete that import so that you pick up the built-in `enumerate`), and code that's doing this is already wrong on so many levels, so I don't feel bad about making this change without a deprecation period. (cherry picked from commit 0227fda)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an
enumerate = enumerateassignment that should no longer be necessary.Technically, this is a backwards incompatible change: anyone who imports
enumeratefromtraits.trait_basewill no longer be able to do so. However, the workaround is immediate (just delete that import so that you pick up the built-inenumerate), and code that's doing this is already wrong on so many levels, so I don't feel bad about making this change without a deprecation period.Checklist
docs/source/traits_api_reference)docs/source/traits_user_manual)traits-stubs