Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require the pkg_resources module to be present for find_resource and store_resource tests #1679

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Require the pkg_resources module to be present for find_resource and store_resource tests #1679

merged 2 commits into from
Aug 4, 2022

Conversation

mdickinson
Copy link
Member

Addresses #1677.

@mdickinson mdickinson merged commit 7e6fd06 into main Aug 4, 2022
@mdickinson mdickinson deleted the fix/resource-tests-require-setuptools branch August 4, 2022 10:11
@mdickinson mdickinson mentioned this pull request Aug 8, 2022
Closed
mdickinson added a commit that referenced this pull request Aug 9, 2022
@mdickinson
Require the pkg_resources module to be present for find_resource and …
d874c41 
…store_resource tests (#1679)

test_store_resource_deprecated was failing on editable installs in environments that didn't have `pkg_resources` available. This PR updates the test to only run when `pkg_resources` is available.

(cherry picked from commit 7e6fd06)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdickinson @rahulporuri