Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rst issues identified by "sphinx-lint" #1652

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Jun 11, 2022

Fix rst issues found by the sphinx-lint linter. Ref https://github.com/sphinx-contrib/sphinx-lint

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

	modified:   .github/workflows/test-documentation-build.yml
@rahulporuri

This comment was marked as outdated.

	modified:   docs/source/changelog.rst
	modified:   docs/source/traits_user_manual/advanced.rst
	modified:   docs/source/traits_user_manual/debugging.rst
@rahulporuri rahulporuri changed the title [WIP] Use "sphinx-lint" in GitHub Actions CI Use "sphinx-lint" in GitHub Actions CI Jun 11, 2022
@rahulporuri rahulporuri changed the title Use "sphinx-lint" in GitHub Actions CI Fix rst issues identified by "sphinx-lint" Jun 13, 2022
.. include:: ../../CHANGES.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: It's not clear from the GitHub diff, but this change is adding a missing trailing newline.

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@rahulporuri rahulporuri merged commit e525c57 into main Jun 13, 2022
@rahulporuri rahulporuri deleted the doc/sphinx-lint branch June 13, 2022 11:44
mdickinson pushed a commit that referenced this pull request Aug 9, 2022
* DEV: Install and run sphinx-lint in docs build CI job

	modified:   .github/workflows/test-documentation-build.yml

* FIX: Fix rst issues discovered by the linter

	modified:   docs/source/changelog.rst
	modified:   docs/source/traits_user_manual/advanced.rst
	modified:   docs/source/traits_user_manual/debugging.rst

* Revert "DEV: Install and run sphinx-lint in docs build CI job"

This reverts commit b214682.

(cherry picked from commit e525c57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants