Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document "Date", "Datetime" and "Time" trait types #1641

Merged
merged 2 commits into from
May 10, 2022
Merged

Document "Date", "Datetime" and "Time" trait types #1641

merged 2 commits into from
May 10, 2022

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented May 10, 2022 •
edited
Loading

fixes #1445

This PR documents the Date, Datetime and Time trait types in the "Predefined Trait Types" section of the user documentation.

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference) These traits are already documented in the API docs.
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

DOC: Document Date, Datetime and Time traits
8df6327 
fixes #1445

	modified:   docs/source/traits_user_manual/defining.rst
mdickinson
mdickinson reviewed May 10, 2022
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; a few nitpick-level comments.

CLN: Address review comments
dd14ebc 
	modified:   docs/source/traits_user_manual/defining.rst
@rahulporuri rahulporuri requested a review from mdickinson May 10, 2022 07:42
@rahulporuri
Copy link
Contributor Author

LGTM; a few nitpick-level comments.

Thanks for the comments - i've addressed them. Can you take another look?

mdickinson
mdickinson approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulporuri rahulporuri merged commit 9af04c7 into main May 10, 2022
@rahulporuri rahulporuri deleted the doc/1445-document-date-time-traits branch May 10, 2022 07:57
mdickinson pushed a commit that referenced this pull request Aug 9, 2022
@mdickinson
Document "Date", "Datetime" and "Time" trait types (#1641)
e3f76a0 
* DOC: Document Date, Datetime and Time traits

fixes #1445

	modified:   docs/source/traits_user_manual/defining.rst

* CLN: Address review comments

	modified:   docs/source/traits_user_manual/defining.rst

(cherry picked from commit 9af04c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Date, Datetime and Time traits in the "Predefined traits" section of the user manual
2 participants
@rahulporuri @mdickinson