Remove the use of cTrait.default_value to set the default value #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Apr 20, 2022
Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com>
…ated-default-value-for-set
|
@rahulporuri Thanks for the review! I've updated. If you have bandwidth for another look, that would be much appreciated. |
rahulporuri
approved these changes
Apr 20, 2022
| +----------------------------------------------------------------------------*/ | ||
|
|
||
| static PyObject * | ||
| _trait_default_value(trait_object *trait, PyObject *args) | ||
| _trait_default_value(trait_object *trait, PyObject *Py_UNUSED(ignored)) |
There was a problem hiding this comment.
Do we need to define a second argument to the _trait_default_value function, which is then marked as ignored (IIUC this is done only to silence compiler warnings)?
There was a problem hiding this comment.
Yes, a second argument is required here. You can see lots of uses of this pattern in the CPython source, too. The function has to be of type PyCFunction (docs here), which is defined as
typedef PyObject *(*PyCFunction)(PyObject *, PyObject *);
There was a problem hiding this comment.
and yes, the Py_UNUSED is there to silence compiler warnings.
There was a problem hiding this comment.
Thanks for the reference and explanation. Still LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
cTrait.default_valueto set the default value type and default value was deprecated in 2019, in #620. This PR removes that deprecated support. To set the default value type and default value for aCTraitorcTraitinstance, useset_default_value.Checklist
docs/source/traits_api_reference) N/Adocs/source/traits_user_manual) N/Atraits-stubsN/A