Remove unused fast validation tuples #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some constants that are no longer needed within Traits, namely
int_fast_validate,float_fast_validateandcomplex_fast_validate. The need forcomplex_fast_validatewas removed in #1594. The other constants haven't been used for some time, except thatfloat_fast_validateis used in a test that verifies validation in the presence of NumPy - I've switched that test to checkbool_fast_validateinstead.These constants aren't exported in any of the
apimodules, so they shouldn't be being used by any other package. A check through the source available to me shows no uses in other packages.