Fix an observe-decorated _name_changed method #1560
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of a method that's decorated with
observe
but also has the magic_somename_changed
naming.Prior to this PR, such a method would be registered twice by the Traits machinery, and called once with a
TraitChangeEvent
and once with the new value of the trait:With this PR, it will only be called once, with the
TraitChangeEvent
: theobserve
decorator supersedes and nullifies the magic naming. This is the same behaviour that's already present foron_trait_change
:I don't think we need a deprecation period for the change in behaviour: I doubt that there's working code that relies on the method being called twice with different arguments for each call, so I think this qualifies as a bugfix.
The PR also adds tests that exercise the corresponding code for
on_trait_change
.Closes #527