Fix dynamic default values for Union traits #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Sep 13, 2021
| if 'default_value' in metadata: | ||
| default_value = metadata.pop("default_value") | ||
| elif self.list_ctrait_instances: |
There was a problem hiding this comment.
The condition here is unnecessary: list_ctrait_instances is always nonempty.
There was a problem hiding this comment.
just to be clear, this is always nonempty because we can't/don't use trait = Union(). right?
There was a problem hiding this comment.
Union() is legal, but it's equivalent to Union(None). That doesn't feel quite right to me (I think I'd prefer an exception), but fixing it is outside the scope of this issue. Code ref:
Lines 3982 to 3983 in 385f42b
mdickinson
commented
Sep 13, 2021
| @@ -27,7 +28,7 @@ def validate(self, obj, name, value): | |||
| self.error(obj, name, value) | |||
|
|
|||
|
|
|||
| class TestCaseEnumTrait(unittest.TestCase): | |||
| class TestUnion(unittest.TestCase): | |||
There was a problem hiding this comment.
Drive-by fix of long-standing copypasta.
rahulporuri
approved these changes
Sep 13, 2021
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the default value for a trait of the form
Union(List(Int), Str)so that appropriate validation is performed on the list.Fixes the Union part of #1520.
Closes #1131.