Raise ValueError on parse failure #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
parsemethod intraits.observation.apito raiseValueErrorinstead ofLarkError. TheLarkErrorexception is an implementation detail that users should be shielded from - we may replace the lark-based parser with some other parser in the future, and users shouldn't have to change their code in that case.I made this change because I found myself wanting to writing tests to check that particular expressions were invalid, and neither of
self.assertRaises(LarkError)norself.assertRaises(Exception)seemed like a palatable option for those tests.Fixes #1504.