Publish NotifierNotFound in traits.observation.api #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Sep 3, 2021
corranwebster
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
Only concern is whether we should keep a dummy _exceptions module that imports from the new exceptions to support code that had to go rummaging around in private modules to get the exception objects.
I'm in two minds: it was private, so code doing this knew what it was getting into; on the other hand it was occasionally necessary due to the issue with the API, so helping code that was forced to do that might be polite.
I think we should be fine without it. A search turned up no uses of |
rahulporuri
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
NotifierNotFoundimportable fromtraits.observation.api, updates the documentation to note thatNotifierNotFoundcan be raised, and adds a test forNotifierNotFoundbeing raised.It also renames the
traits.observation._exceptionmodule totraits.observation.exception, in keeping with that package's conventions for public versus private objects.Closes #1479.
Checklist
docs/source/traits_api_reference)docs/source/traits_user_manual)[ ] Update type annotation hints inN/Atraits-stubs