-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration file for Read the Docs #1478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The built docs on readthedocs look good to me.
- method: pip | ||
path: . | ||
extra_requirements: | ||
- docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this means python -m pip install .[docs]
? It's not clear from the docs page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. I think there's an example in the RtD docs that makes this somewhat clear, but you're right that it doesn't seem to be spelled out explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, I was looking at the bit just after the text "With the previous settings, Read the Docs will execute the next commands:"
This PR adds a basic configuration file for Read the Docs. This file was sufficient to get the RtD build passing. See https://traits.readthedocs.io/en/docs-readthedocs-config/ for the documentation built from this branch.