Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation build #1462

Merged
merged 4 commits into from
May 13, 2021
Merged

Fix documentation build #1462

merged 4 commits into from
May 13, 2021

Conversation

mdickinson
Copy link
Member

The documentation build is now picking up Sphinx 4.0.1, and is breaking as a result. We need to fix that, but short term we also need to pin Sphinx to a version < 4.0 so that other PRs (like #1461) can be merged.

I'm making this PR to both confirm the breakage independently of #1461, and to fix it. I'm expecting the doc build to fail until I pin Sphinx in a separate commit.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit d8d4e8f into master May 13, 2021
@mdickinson mdickinson deleted the fix/doc-build-pin-sphinx branch May 13, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants