Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to regularly test PyPI install #1406

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jan 18, 2021

This PR adds a workflow to regularly test an installation of Traits and its test dependencies from PyPI.

Plan:

  • Get the workflow working, with trigger being "pull-request"
  • Change the trigger to a cron job, running twice monthly.

@mdickinson
Copy link
Member Author

Note: once wheels are published, I'll expand this workflow to also test PyPI installs from wheels.

Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: once wheels are published, I'll expand this workflow to also test PyPI installs from wheels.

Does this need an issue or is that overkill?

Comment on lines +5 to +6
# Run at 03:27 UTC on the 8th and 22nd of every month
- cron: '27 3 8,22 * *'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the reference is here. Nothing actionable here, just wondering.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By "reference" you mean documentation reference?

It's following the same "crontab" format as standard Unix cron. Main docs are here. More here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I mean't why at 03:27 UTC on the 8th and 22nd?

Copy link
Member Author

@mdickinson mdickinson Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. No particular reference. I just wanted a time that was outside normal working hours for both UK and US, and didn't match times that might be used in other cron jobs. The 8th (gah; sorry; the 22nd) was chosen so that this workflow first runs on the day after the 6.2.0 release, while I might still remember to check it.

@mdickinson
Copy link
Member Author

Does this need an issue or is that overkill?

Done in #1407. I've assigned it to this milestone - the ideal is that it should run on Friday morning for the wheels that (if all goes well) were created and uploaded to PyPI after Thursday's release.

@mdickinson mdickinson merged commit d838ba0 into master Jan 18, 2021
@mdickinson mdickinson deleted the ci/test-pypi-install branch January 18, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants