-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow for building and uploading wheels #1404
Conversation
This PR is ready for review. I haven't yet provided values for the PyPI upload environment variables, in case we want to do any more tinkering with the workflow prior to merge. I'll add the secrets once the PR is finalised and approved for merge. |
Suggestion for reviewers: in addition to reviewing the workflow itself, review the workflow output for commit d6128c0. Then review the changes since that commit to verify that I haven't changed anything that would invalidate the workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
||
on: | ||
release: | ||
types: [published] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to add a prereleased
to this list to test this workflow/wheels with a 6.2.0 prerelease?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I think published
covers pre-releases as well as releases. The documentation isn't 100% clear and leads you down a maze of twisty little passages, but I ended up here: https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#release
And that says:
- prereleased: a pre-release is created
- published: a release, pre-release, or draft of a release is published
In addition, the main page https://docs.github.com/en/actions/reference/events-that-trigger-workflows#release says:
Note: The release event is not triggered for draft releases.
So I think just published
is what I need here.
Valid secrets have been added; this PR should be ready to merge. |
This PR adds a workflow for automatically building and uploading source distribution and wheels to PyPI when a Traits release is published.
Still to do:
twine upload
step. That step is expected to fail due to invalid permissionsNotes
MACOSX_DEPLOYMENT_TARGET=10.14
, so the wheels built won't work on macOS versions earlier than 10.14Closes #357.