-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intro tutorial which pulls content from interactive examples #1374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos noted in passing; I haven't tested the changes in either the built documentation or the demo app.
Co-authored-by: Mark Dickinson <mdickinson@enthought.com>
Closing and re-opening to retrigger CI build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this with the demo application. Looks fine in general but the code snippet looks slightly odd but I think it is an existing issue, hence orthogonal:
I have also tested the HTML sphinx documentation locally. Links are working and the rendering looks fine there.
However I find the "Tutorials" link is mentioned too early in the main page compared to the high-level introduction (see another comment):
:maxdepth: 3 | ||
|
||
traits_tutorial/index | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This being at the top makes it more likely the first thing a developer would read. But I think the Introduction section is more suitable as the first thing to read because it provides a higher-level summary of the capabilities of Traits: https://docs.enthought.com/traits/traits_user_manual/intro.html#introduction
I'd think this tutorial needs to be read after the introduction because it assumes one knows what Traits is for, is interested in it, and wanted to start learning to use it.
Once we establish a structure of our documentation to contain gentle guides/tutorials/API references/example snippets, it will likely get replicated to other ETS repository. So it might be worth thinking about this earlier.
(I personally like sqlalchemy's documentation (e.g. Version 1.3). Its landing page guides you through an overview, installation, and then provide links to tutorial and API references.)
I merged master in to fix (I hope) the unrelated CI failures. |
That looks like it's not picking up the CSS for the HTML view? |
I'd like to get this in for the impending Traits 6.2 release. There are some important discussions going on, and I don't want to shut those down. But on the basis that
I'd like to merge this. @kitchoi, @corranwebster are there any points that you think it's really important to address before this is merged? |
Agreed that a doc with tutorial is a net improvement. But the order in the index feels odd enough to me that I'd propose somehow making tutorial follow the "Introduction". I will have a look in how the TOC can be changed to make that happen. |
See #1394 |
@mdickinson Please do go ahead to close/merge #1394 and this one as you see fit. When I opened #1394, I really did not think it would be objected to because the ordering was apparently odd to me - it was not my intention to slow down progress. |
I took the liberty of fixing a hyphenation nitpick; will merge when CI signs off. I'll open a new issue for refactoring of the landing page. |
Opened #1413. |
This extracts and links to the introduction to traits tutorial in traits/examples and makes it available via the documentation.
Done this way rather than copying so we have one source for the actual content.
No new, code, just documentation.
Checklist
TestsUpdate API reference (docs/source/traits_api_reference
)Update User manual (docs/source/traits_user_manual
)Update type annotation hints intraits-stubs