Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intro tutorial which pulls content from interactive examples #1374

Merged
merged 5 commits into from
Jan 20, 2021

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Dec 9, 2020

This extracts and links to the introduction to traits tutorial in traits/examples and makes it available via the documentation.

Done this way rather than copying so we have one source for the actual content.

No new, code, just documentation.

Checklist

  • Tests
  • Update API reference (docs/source/traits_api_reference)
  • Update User manual (docs/source/traits_user_manual)
  • Update type annotation hints in traits-stubs

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos noted in passing; I haven't tested the changes in either the built documentation or the demo app.

docs/source/traits_tutorial/introduction.rst Outdated Show resolved Hide resolved
docs/source/traits_tutorial/introduction.rst Outdated Show resolved Hide resolved
docs/source/traits_tutorial/introduction.rst Outdated Show resolved Hide resolved
Co-authored-by: Mark Dickinson <mdickinson@enthought.com>
@mdickinson
Copy link
Member

Closing and re-opening to retrigger CI build

@mdickinson mdickinson closed this Jan 4, 2021
@mdickinson mdickinson reopened this Jan 4, 2021
Copy link
Contributor

@kitchoi kitchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this with the demo application. Looks fine in general but the code snippet looks slightly odd but I think it is an existing issue, hence orthogonal:
Screenshot 2021-01-04 at 10 39 01

I have also tested the HTML sphinx documentation locally. Links are working and the rendering looks fine there.

However I find the "Tutorials" link is mentioned too early in the main page compared to the high-level introduction (see another comment):
Screenshot 2021-01-04 at 11 19 55

:maxdepth: 3

traits_tutorial/index

Copy link
Contributor

@kitchoi kitchoi Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This being at the top makes it more likely the first thing a developer would read. But I think the Introduction section is more suitable as the first thing to read because it provides a higher-level summary of the capabilities of Traits: https://docs.enthought.com/traits/traits_user_manual/intro.html#introduction

I'd think this tutorial needs to be read after the introduction because it assumes one knows what Traits is for, is interested in it, and wanted to start learning to use it.

Once we establish a structure of our documentation to contain gentle guides/tutorials/API references/example snippets, it will likely get replicated to other ETS repository. So it might be worth thinking about this earlier.

(I personally like sqlalchemy's documentation (e.g. Version 1.3). Its landing page guides you through an overview, installation, and then provide links to tutorial and API references.)

@mdickinson
Copy link
Member

I merged master in to fix (I hope) the unrelated CI failures.

@corranwebster
Copy link
Contributor Author

I have tested this with the demo application. Looks fine in general but the code snippet looks slightly odd but I think it is an existing issue, hence orthogonal:

That looks like it's not picking up the CSS for the HTML view?

@mdickinson
Copy link
Member

mdickinson commented Jan 14, 2021

I'd like to get this in for the impending Traits 6.2 release. There are some important discussions going on, and I don't want to shut those down. But on the basis that

  • The docs with the tutorial are a (huge) net improvement over the docs without the tutorial, and
  • We can continue to refine the documentation after the release

I'd like to merge this. @kitchoi, @corranwebster are there any points that you think it's really important to address before this is merged?

@mdickinson mdickinson added this to the 6.2.0 release milestone Jan 14, 2021
@kitchoi
Copy link
Contributor

kitchoi commented Jan 14, 2021

Agreed that a doc with tutorial is a net improvement. But the order in the index feels odd enough to me that I'd propose somehow making tutorial follow the "Introduction". I will have a look in how the TOC can be changed to make that happen.

@kitchoi
Copy link
Contributor

kitchoi commented Jan 14, 2021

See #1394

@kitchoi
Copy link
Contributor

kitchoi commented Jan 18, 2021

@mdickinson Please do go ahead to close/merge #1394 and this one as you see fit. When I opened #1394, I really did not think it would be objected to because the ordering was apparently odd to me - it was not my intention to slow down progress.

@mdickinson
Copy link
Member

I took the liberty of fixing a hyphenation nitpick; will merge when CI signs off.

I'll open a new issue for refactoring of the landing page.

@mdickinson
Copy link
Member

I'll open a new issue for refactoring of the landing page

Opened #1413.

@mdickinson mdickinson merged commit 5ad3d9b into master Jan 20, 2021
@mdickinson mdickinson deleted the docs/intro-tutorial branch January 20, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants