Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor package_data nit #1363

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix minor package_data nit #1363

merged 1 commit into from
Nov 17, 2020

Conversation

mdickinson
Copy link
Member

This PR fixes a minor setup.py nit: package_data should be listed by package. So now that traits.examples is a package, we can adjust the package_data listing accordingly.

xref: #1348, #1358

Checklist

  • Tests N/A, but needs manual testing
  • Update API reference (docs/source/traits_api_reference) N/A
  • Update User manual (docs/source/traits_user_manual) N/A
  • Update type annotation hints in traits-stubs N/A

rahulporuri
rahulporuri approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson merged commit b2592d7 into master Nov 17, 2020
@mdickinson mdickinson deleted the nit/traits-examples-package-data branch November 17, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdickinson @rahulporuri