Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lru cache size magic number of 128 with a module level constant #1345

Merged
merged 1 commit into from
Nov 11, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion traits/observation/parsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@

_LARK_PARSER = _generated_parser.Lark_StandAlone()

#: Maximum number of parsed observer expressions stored in the LRU cache
_OBSERVER_EXPRESSION_CACHE_MAXSIZE = 128


def _handle_series(trees, default_notifies):
""" Handle expressions joined in series using "." or ":" connectors.
Expand Down Expand Up @@ -254,7 +257,7 @@ def _handle_tree(tree, default_notifies=None):
tree.children, default_notifies=default_notifies)


@lru_cache(maxsize=128)
@lru_cache(maxsize=_OBSERVER_EXPRESSION_CACHE_MAXSIZE)
def parse(text):
""" Top-level function for parsing user's text to an ObserverExpression.

Expand Down