-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use released Python 3.9 instead of prerelease #1303
Conversation
For Appveyor, looks like we don't have 3.9 yet: appveyor/ci#3541. I suspect that's also true for Travis. I'll open an issue to remind us to update those eventually. |
Updated to drop Python 3.5 runs and add Python 3.8 runs for Appveyor, partially addressing #1304. |
There still seem to be issues with PySide 2 on Windows (both 32-bit and 64-bit). Here's the error for the 64-bit run (the error for the 32-bit run is almost identical).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you please update the description to mention that 3.5 was dropped from CI before merging? |
Done. Before merging, I'm just going to quickly try replacing 3.9-dev with 3.9 for Travis. It probably won't work, but I can't find any information online about 3.9 support for Travis CI, and this seems like the quickest way to find out whether it's supported. |
Failed as expected:
|
This reverts commit 1b29889.
Random(?) failure on the Python 3.6 Linux Travis CI job:
I'll restart that job. |
Python 3.9 has been released, so we should update the GitHub Actions continuous integration to run on 3.9 proper instead of on a pre-release version.
This PR updates the GitHub Actions test script accordingly.
xref: actions/setup-python#148
We should also update the Travis and Appveyor scripts, but I'm having difficulty finding evidence that the systems support Python 3.9 yet. I'll give it a try once the GitHub Actions change has completed.
EDIT: Updated to also drop Python 3.5 support for both Appveyor and Travis CI.