Refactor and simplify HasTraits method checks #1176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HasTraits
machinery needs function and method checks at various points, mostly to look for magic-named methods like_mytrait_changed
and_myevent_fired
.Those checks are currently performed inconsistently, and for methods written in Cython also rely on a rather fragile mechanism for recognising the method. (That mechanism also fails for C extensions other than Cython extensions.)
This PR:
_is_unbound_method_type
helper function.inspect.ismethoddescriptor
as a better way to catch something that behaves like an unbound method without relying on Cython-specific details