Add missing changelog entry for PR that will be backported #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Note: I'm not adding a changelog entry for this PR. :-) |
mdickinson
added a commit
that referenced
this pull request
Jun 1, 2020
(cherry picked from commit 94a3dca)
mdickinson
added a commit
that referenced
this pull request
Jun 1, 2020
* Nitpick: call the repr function rather than the corresponding dunder method in tests (#1148) (cherry picked from commit 4dedd10) * Fix mutation of global state by a test (#1149) * Fix mutation of global state by a test * Add changelog entries for this PR and #1148 (cherry picked from commit 3c2be48) * Maint: Improve validation error message and free PrefixList from subclassing BaseStr (#1147) * Free PrefixList from BaseStr and use value_for * Update changelog with the PR number * Expand existing test to check error message * Improve error message * Improve the error message for value_for (cherry picked from commit 92fc45d) * Add missing Py_DECREF to fix a reference leak (#1152) * Add missing Py_DECREF to fix a reference leak * Add changelog entry (cherry picked from commit 7ac415e) * DOC: Expand user manual on migration from Either to Union (#1153) * Expand user manual on migration from Either to Union * Minor improvement to the documentation * More direct instruction * Add PR reference to changelog on Union * Move to the Documentation section in the changelog * Backticks... (cherry picked from commit 60dab76) * Remove logging configuration for logging observe's change handler failure (#1156) * Remove configuration on logger * Move logger to the module level * Use warnings instead * Import order * Revert "Import order" This reverts commit eb75162. * Revert "Use warnings instead" This reverts commit 420eab0. (cherry picked from commit d4f3011) * Fix some DeprecationWarnings from the test suite (#1157) * Fix some DeprecationWarnings from the test suite * Add changelog entry * Fix long line and line spacing issue * Fix reST error in docstring (cherry picked from commit b8a9c67) * Add changelog link to the Either-to-Union migration guide (#1162) * Add changelog link to the Either-to-Union migration guide * Add changelog entry for this PR (cherry picked from commit 1f99855) * Don't configure logging for trait notification handler exceptions (#1161) * Don't configure logging * Add changelog entry * Add test to check that logs are created * Add note about log configuration to the 'Notes on upgrading' section * Wording tweak * Update changelog wording * More wording tweaks * Fix another typo (cherry picked from commit e60feb2) * Add missing changelog entry for PR that will be backported (#1166) (cherry picked from commit 94a3dca) Co-authored-by: Kit Choi <kitchoi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial PR to add #1156 to the 6.1 changelog. Doing this in master so that I don't have to cherry-pick it back to master after the release.