Implement SetItemObserver for observing mutations on a set #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
==========================================
- Coverage 76.15% 73.79% -2.37%
==========================================
Files 54 74 +20
Lines 6493 8353 +1860
Branches 1263 1592 +329
==========================================
+ Hits 4945 6164 +1219
- Misses 1205 1809 +604
- Partials 343 380 +37
Continue to review full report at Codecov.
|
…ll. Remove protection to be consistent with ListItemObserver post-review.
mdickinson
reviewed
May 14, 2020
mdickinson
reviewed
May 14, 2020
| # then | ||
| event, = events | ||
| self.assertEqual(event.added, set([4])) | ||
| self.assertEqual(event.removed, set([])) |
There was a problem hiding this comment.
Nitpick: set() is the usual way to spell the empty set. (Could also use {4} in the line above.)
mdickinson
reviewed
May 14, 2020
|
|
||
|
|
||
| def create_observer(**kwargs): | ||
| """ Convenient function for creating SetItemObserver with default values. |
There was a problem hiding this comment.
typo: "Convenient" -> "Convenience"
mdickinson
reviewed
May 14, 2020
|
One typo to fix and merge conflicts to sort out; other than that, I think this is ready to merge. |
kitchoi
commented
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements item 10 of #977 for observing mutations on a set (strictly speaking, TraitSet).
SetChangeEventto represent mutations on a setIObserverinterface to- Define the notifier such that
SetChangeEventwill be created for the user's change handler.- Implement logic for maintaining downstream observers
IObservableforTraitSet. With that, any subclass ofTraitSetcan be used with SetItemObserver.Checklist
docs/source/traits_api_reference)Update User manual (docs/source/traits_user_manual)Update type annotation hints intraits-stubs