Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TraitSetEvent arguments keyword-only #1036

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Make TraitSetEvent arguments keyword-only #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions traits/tests/test_trait_dict_list_set_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ def test_list_repr(self):
self.assertEqual(event.__repr__(), event_str)
self.assertIsInstance(eval(event.__repr__()), TraitListEvent)

def test_dict_event_kwargs_only(self):
with self.assertRaises(TypeError):
TraitDictEvent({}, {'black': 0}, {'blue': 2})

def test_dict_event_repr(self):
self.foo.adict.update({'blue': 10, 'black': 0})
event = self.foo.event
Expand All @@ -49,6 +53,10 @@ def test_dict_event_repr(self):
self.assertEqual(event.__repr__(), event_str)
self.assertIsInstance(eval(event.__repr__()), TraitDictEvent)

def test_set_event_kwargs_only(self):
with self.assertRaises(TypeError):
TraitSetEvent({3}, {4})

def test_set_event_repr(self):
self.foo.aset.symmetric_difference_update({3, 4})
event = self.foo.event
Expand Down
4 changes: 2 additions & 2 deletions traits/trait_set_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class TraitSetEvent(object):
New values added to the set.
"""

def __init__(self, removed=None, added=None):
def __init__(self, *, removed=None, added=None):

if removed is None:
removed = set()
Expand Down Expand Up @@ -529,7 +529,7 @@ def notifier(self, removed, added):
if object is None:
return

event = TraitSetEvent(removed, added)
event = TraitSetEvent(removed=removed, added=added)
items_event = self.trait.items_event()
object.trait_items_event(self.name_items, event, items_event)

Expand Down