Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etstool to work with non-edm bootstrap env on win #203

Merged
merged 2 commits into from
Sep 13, 2019

Conversation

rahulporuri
Copy link
Contributor

@rahulporuri rahulporuri commented Sep 13, 2019

the changes are borrowed from enthought/traits#512
fixes #163

the changes are borrowed from
enthought/traits#512

	modified:   etstool.py
@rahulporuri rahulporuri changed the title Update etstool to work with non-edm bootstrap env Update etstool to work with non-edm bootstrap env on win Sep 13, 2019
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson mdickinson mentioned this pull request Sep 13, 2019
28 tasks
and explicitly pass runtime and toolkit to the env name if its
not defined

	modified:   etstool.py
@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #203 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   46.42%   45.97%   -0.46%     
==========================================
  Files         143      147       +4     
  Lines        4517     4566      +49     
  Branches      504      506       +2     
==========================================
+ Hits         2097     2099       +2     
- Misses       2374     2422      +48     
+ Partials       46       45       -1
Impacted Files Coverage Δ
...ge/plugins/refresh_code/refresh_code_action_set.py 0% <0%> (ø)
envisage/plugins/refresh_code/actions.py 0% <0%> (ø)
...visage/plugins/refresh_code/refresh_code_plugin.py 0% <0%> (ø)
...ins/refresh_code/refresh_code_plugin_definition.py 0% <0%> (ø)
envisage/composite_plugin_manager.py 86.84% <0%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adeda00...598bc2d. Read the comment docs.

@mdickinson mdickinson merged commit 679acfc into master Sep 13, 2019
@mdickinson mdickinson deleted the fix/163-bootstrap-env-win branch September 13, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etstool.py won't work from a non-EDM environment on Windows
3 participants