Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid build isolation when installing source dependencies #322

Closed
wants to merge 1 commit into from
Closed

Avoid build isolation when installing source dependencies #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion etstool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,20 @@ def install(edm, runtime, environment, source):
source_pkgs = [
github_url_fmt.format(pkg) for pkg in source_dependencies
]

# Install build prerequisites from EDM (needed because we're avoiding
# build isolation below).
commands = ["{edm} install -y -e {environment} setuptools wheel"]
execute(commands, parameters)

# --no-build-isolation is necessary to temporarily work around
# an incompatibility between setuptools >= 65.2.0 and the EDM runtimes.
# See enthought/traits#1721.
commands = [
"python -m pip install {pkg} --no-deps".format(pkg=pkg)
(
"python -m pip install --no-build-isolation "
"{pkg} --no-deps"
).format(pkg=pkg)
for pkg in source_pkgs
]
commands = [
Expand Down