Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticCompoundQueries update to 2.1.0 #1288

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Conversation

V-Brooks
Copy link
Collaborator

@V-Brooks V-Brooks commented Jan 25, 2021

Changes

  • Update SemanticCompoundQueries to 2.1.0

Issues

  • Previous version (1.2.0) was not compatible with MW, SMW, and PHP

Post-merge actions

Post-merge, the following actions need to be addressed:

@jamesmontalvo3
Copy link
Contributor

Nice, thanks!

@jamesmontalvo3 jamesmontalvo3 merged commit 6650a7a into master Jan 26, 2021
@jamesmontalvo3 jamesmontalvo3 deleted the SCQ-update-2-1-0 branch January 26, 2021 09:07
version: "1.2.0"
version: "2.1.0"
config: |
wfLoadExtension( 'SemanticCompoundQueries' );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this wfLoadExtension.... call under config is necessary. I believe Meza calls wfLoadExtension when it reads this yaml file. I think "config" field can be left blank

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't confirm if it's necessary or not but when I submitted d210b7a, Wiki never loaded the extension until I added the wfLoadExtension in ccee3e5.

I'll try to test this out more and will reply here with the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants