Remove PEAR, install net_smtp via composer.local.json #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meza has used PEAR to install the mail and net_smtp packages per the docs at https://www.mediawiki.org/wiki/Manual:$wgSMTP. However, since MW 1.31 pear/mail is packaged with MW (in composer.json). In MW 1.32 net_smtp is also in composer.json. This commit is on a version of Meza using MW 1.31, so pear/net_smtp needs to be added via composer.local.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Meza has historically used PEAR to install the
mailandnet_smtppackages per the docs at https://www.mediawiki.org/wiki/Manual:$wgSMTP. However, since MW 1.31pear/mailis packaged with MW (incomposer.json). In MW 1.32net_smtpis also incomposer.json. This commit is on a version of Meza using MW 1.31, sopear/net_smtpneeds to be added viacomposer.local.json.This change initiated by the fact that PEAR has had a security breach and is down. Ref iuscommunity-pkg/pear1u#3. Since PEAR isn't needed anymore we're removing its usage so builds will pass.
Additionally, I accidentally added a fix for
meza delete elasticsearch <environment>to this commit. Variables were not properly being loaded. Rather than split this fix out and slow down getting builds passing again I'm going to merge as-is.Issues
None
Post-merge actions
Post-merge, the following actions need to be addressed: