Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config.sh|php into separate role to allow quick update for autodeployer #1026

Merged
merged 8 commits into from
Sep 30, 2018

Conversation

jamesmontalvo3
Copy link
Contributor

@jamesmontalvo3 jamesmontalvo3 commented Sep 30, 2018

Changes

  • config.sh and config.php moved out of base role and into base-config-scripts role
  • setbaseconfig.yml playbook created to just update these scripts
  • meza setbaseconfig ENV command created for quick update
  • Add to autodeployer: update config.sh (and config.php, but that doesn't matter for autodeployer) at beginning of autodeployer to pick up any changes from Secret config (which isn't currently managed by autodeployer). Then again update config.sh after Public config change in case changes impact config.sh.
  • Make it so notifications include list of commits involved in all changes.

Issues

  • Still open issue: Autodeployer currently does not do a full deploy. It does an incredibly minimal deploy in order to move quickly for testing. Unfortunately to test this easily in production it's better to use the master branch. Since autodeployer is a new feature it's not really breaking anything.

Post-merge actions

Post-merge, the following actions need to be addressed:

@jamesmontalvo3 jamesmontalvo3 added the open post-merge actions Pull request that has incomplete post-merge actions label Sep 30, 2018
@jamesmontalvo3 jamesmontalvo3 merged commit 8c0242f into master Sep 30, 2018
@jamesmontalvo3 jamesmontalvo3 deleted the dev branch September 30, 2018 19:37
@jamesmontalvo3 jamesmontalvo3 removed the open post-merge actions Pull request that has incomplete post-merge actions label Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant