-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forgiveness #79
Forgiveness #79
Conversation
WatchAnalytics has never had a release before. I just cut an arbitrary FYI, I also made Meza track specific versions of every other extension EMW maintains. |
modules/clearpendingreviews/ext.watchanalytics.clearpendingreviews.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting things listed are just suggestions. I think they'll make the special page better, but I'll merge without them. The change
versus keyup
/keydown
thing I think is critical.
One other thing that I'm not sure how to comment on in code below: have you considered what may cause a request to timeout? I did some wider time ranges and preview took a long time. Of course this isn't intended for wide time ranges, and I think you hope to add some validation to prevent such ranges at some point, but I'm not sure if you'd get similar long response times for a short time range but with a large number of reviews... e.g. if a ReplaceText edited 1000s of pages in a short period of time. Could that cause a timeout? And could that timeout be prevented by limiting the number of pages/people shown in the preview? Something like "this preview would exceed X pages and cannot be displayed. You can choose to blindly clear the reviews anyway at your own peril, but it is recommended you further limit your query instead."
modules/clearpendingreviews/ext.watchanalytics.clearpendingreviews.js
Outdated
Show resolved
Hide resolved
I incorporated all of your feedback except for the timeout limit, trying to think of best way to handle that. I don't think that is a required change before merging this but I will work it in the future. I also added Hooks to the Preview and Clear Pages actions so we could tie in slackbots or whatever we want with those |
Adds special page:ClearPendingReviews to allow for users with userright:clearreview the ability to clear pending reviews without the need of using the terminal