Adds nav button during page review #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made one more commit that closes #39 . I'm done making changes now and am ready for @jamesmontalvo3 to review this now |
extension.json
Outdated
| @@ -207,6 +207,7 @@ | |||
| "_prefix": "eg", | |||
| "WatchAnalyticsPageCounter": false, | |||
| "WatchAnalyticsShowUnreviewDiff": true, | |||
| "WatchAnalyticsHidePrintScores": true, | |||
There was a problem hiding this comment.
Why would we want this as an option? Scores aren't very useful on a printed page since you can't hover over them and see what they mean.
There was a problem hiding this comment.
I was thinking someone may want to have the scores on a printed page but you're right about them not being very useful in that form.
I removed the option and hardcoded the pagescores to not show in print view
|
Baller. I like Schrödinger's Diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user scrolls past the review block on a wiki page a button will appear at the top of the page to A) indicate to the user that they are reviewing the page and B) allow them to easily navigate to the review block.