Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capsule integration final #883

Open
wants to merge 74 commits into
base: main
Choose a base branch
from
Open

Capsule integration final #883

wants to merge 74 commits into from
+2,701 −1,724

Conversation

LeonmanRolls
Copy link
Member

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 25, 2024 •
edited
Loading

Deploying ens-app-v3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2c4343e
Status: ✅  Deploy successful!
Preview URL: https://30f2e1c0.ens-app-v3.pages.dev
Branch Preview URL: https://capsule-integration-final.ens-app-v3.pages.dev

View logs

@LeonmanRolls LeonmanRolls marked this pull request as ready for review October 24, 2024 04:36
@LeonmanRolls LeonmanRolls requested a review from sugh01 as a code owner October 24, 2024 04:36
TateB
TateB requested changes Oct 24, 2024
View reviewed changes
src/components/ConnectButton.tsx Outdated Show resolved Hide resolved
src/components/ConnectButton.tsx Outdated Show resolved Hide resolved
src/pages/_app.tsx Outdated Show resolved Hide resolved
src/utils/query/RainbowKitWithCapsuleProvider.tsx Outdated Show resolved Hide resolved
src/utils/query/capsuleWallet.ts Outdated Show resolved Hide resolved
src/utils/query/capsuleWallet.ts Outdated Show resolved Hide resolved
src/utils/query/wagmi.ts Show resolved Hide resolved
storywithoutend
storywithoutend requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@storywithoutend storywithoutend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-23 at 12 18 16 PM When not connected, testnet shows holesky

storywithoutend
storywithoutend requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@storywithoutend storywithoutend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you log out and log in with capsule, sometimes the will not update to connected. You have to click connect > sign in with capsule in order for it to trigger login.

src/components/@molecules/TransactionDialogManager/stage/TransactionStageModal.tsx Show resolved Hide resolved
storywithoutend
storywithoutend requested changes Jan 23, 2025
View reviewed changes
src/components/pages/profile/[name]/registration/steps/Pricing/Pricing.tsx Show resolved Hide resolved
src/constants/chains.ts Outdated Show resolved Hide resolved
src/constants/chains.ts Show resolved Hide resolved
src/hooks/pages/profile/useRenew/useRenew.test.ts Show resolved Hide resolved
src/utils/query/capsuleWallet.ts Show resolved Hide resolved
src/utils/query/capsuleWallet.ts Show resolved Hide resolved
src/utils/query/capsuleWallet.ts Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storywithoutend storywithoutend storywithoutend requested changes

@TateB TateB TateB requested changes

@sugh01 sugh01 Awaiting requested review from sugh01 sugh01 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeonmanRolls @storywithoutend @TateB @jlm0