This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Move libxslt to (optional) peerDependencies, devDependencies #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses enketo/enketo#760 (though slightly differently). I had meant to address this in #171, but it must have slipped my mind.
As an optional peer dependency, client-only usage will be able to skip installing
libxslt
entirely. Server transform users (including enketo-core and enketo-express, though core can and should be updated to use the client transform) will need to explicitly installlibxslt
directly.This is technically a breaking change, and maybe should be released as semver-major. But I think the impact should be fairly minimal because
npm
will message about the uninstalled peer dependency, and Node will error if importinglibxslt
fails.