[PLA-2055] Fix CreateFuelTankMutation on no dispatchRule

[leonardocustodio]

PR Type

Bug fix

---

Description

• Fixed a potential error in the addPermittedExtrinsics method of CreateFuelTankMutation by adding a check to ensure dispatchRules is not empty before accessing its first element.
• Improved error handling to prevent null reference issues.

---

Changes walkthrough 📝

	Relevant files
Bug fix	CreateFuelTankMutation.php Fix potential error when `dispatchRules` is empty                src/GraphQL/Mutations/CreateFuelTankMutation.php Added a check to ensure dispatchRules is not empty before accessing its first element. Prevented potential errors when dispatchRules is empty. +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Handling The added check for empty dispatchRules or null permittedExtrinsics might not handle all edge cases. Consider adding more comprehensive checks or handling for other potential null or unexpected values within dispatchRules.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Prevent errors by ensuring the first element of $dispatchRules is an object with the necessary properties before accessing it Check if $dispatchRules is not only non-empty but also contains an object with a defined permittedExtrinsics property before accessing it. This prevents potential errors when $dispatchRules is empty or the first element is not an object or lacks the permittedExtrinsics property. src/GraphQL/Mutations/CreateFuelTankMutation.php [131-132] -if (empty($dispatchRules) || $dispatchRules[0]->permittedExtrinsics === null) { +if (empty($dispatchRules) || !is_object($dispatchRules[0]) || $dispatchRules[0]->permittedExtrinsics === null) { return $encodedData; } Suggestion importance[1-10]: 8 Why: The suggestion improves the robustness of the code by checking if the first element of $dispatchRules is an object before accessing its properties. This prevents runtime errors in cases where $dispatchRules might not contain an object or the object does not have the permittedExtrinsics property.	8