Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Optimize cli by reducing HTTP calls #30

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

chore: Optimize cli by reducing HTTP calls #30

wants to merge 7 commits into from

Conversation

lperdereau
Copy link
Collaborator

No description provided.

plaffitt
plaffitt requested changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@plaffitt plaffitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from a small bug. But I would like to discuss some parts of the code that we could write in another way IMHO.

src/pvecontrol/cluster.py Outdated Show resolved Hide resolved
src/pvecontrol/cluster.py Outdated Show resolved Hide resolved
src/pvecontrol/node.py Outdated Show resolved Hide resolved
src/pvecontrol/vm.py Show resolved Hide resolved
@plaffitt plaffitt mentioned this pull request Dec 30, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plaffitt plaffitt plaffitt requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lperdereau @plaffitt