Update to Play 3.x. Drop Scala 2.12 support.

[OlegYch]

No description provided.

[julienrf]

I believe the CI failure is caused by this change in the test suite.

[OlegYch]

@julienrf perhaps it needs new julienrf/endpoints4s-stubserver docker image?

[julienrf]

In the commit I linked at least, the stub-server wasn’t changed, so it may not need an update. If you look at the commit it changed the behavior of the servers (and their test expectation), so I think you need to apply the same change here. Unfortunately, that part of the code is a bit complex, so feel free to ask any question if needed!

That being said, if you want to update the stub-server, I invite you to use the same approach as here, which does not go through the Docker hub (which does not contain up to date images): https://github.com/endpoints4s/xhr/blob/f309656a4186f04474f218b65fff5f7ae247a8fe/.github/workflows/ci.yml#L23

[OlegYch]

@julienrf i fixed the test, but i'm not sure if that's the correct way - what happens if there are several endpoints with same method, but different urls and authentication? will the new implementation match the first endpoint it finds and return failure even if there are unauthenticated endpoints that should match?

[codecov]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (9b60787) 58.25% compared to head (6752b82) 56.38%.

Files	Patch %	Lines
.../endpoints4s/play/server/BasicAuthentication.scala	14.28%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   58.25%   56.38%   -1.88%     
==========================================
  Files          21       22       +1     
  Lines         539     1050     +511     
  Branches       20       27       +7     
==========================================
+ Hits          314      592     +278     
- Misses        225      458     +233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[julienrf]

what happens if there are several endpoints with same method, but different urls and authentication? will the new implementation match the first endpoint it finds and return failure even if there are unauthenticated endpoints that should match?

I am not sure I understand completely the part “different URLs”, because if they have different URLs then they may not match the same incoming request, right? But otherwise, yes, the first endpoint whose method + URL path match the incoming request will handle the request. If that endpoint requires authentication, it will return an Unauthorized response if the credentials are missing or invalid, without giving a chance to another endpoint to handle the request.

[julienrf]

I am surprised that you don’t also need to match the URL path 🤔

[julienrf]

Do you think it would be possible to implement it by still calling matchRequestAndParseHeaders?

[OlegYch]

yeah, this is no good, i'll reimplement
can i suggest adding something to testkit that can check if endpoints clash?

like this

  "basic auth" should {
    "not prevent other endpoints from matching" in {
      val response = "Hello!"
      import serverApi._
      val protectedEndpointWithParameter = authenticatedEndpoint(
        Get,
        path / "users" / segment[Long]("id"),
        ok(textResponse)
      )
      val unprotectedEndpointWithParameter = endpoint(
        get(path / "users"),
        ok(textResponse)
      )

      serveRoutes(
        routesFromEndpoints(
          protectedEndpointWithParameter.implementedBy(_ => Some(response)),
          unprotectedEndpointWithParameter.implementedBy(_ => response),
        )
      ){ port =>
        val request = HttpRequest(uri = s"http://localhost:$port/users")
        whenReady(sendAndDecodeEntityAsText(request)) { case (_, entity) =>
          entity shouldBe response
          ()
        }
      }
    }
  }

[julienrf]

Yes, any addition to the test kit is welcome!

[julienrf]

To fix the CI failure you need to relax the compatibility intention to Compatibility.None here (since I assume Play 3 is not binary compatible with Play 2.9):

play/build.sbt

Line 9 in 9b60787

versionPolicyIntention := Compatibility.BinaryAndSourceCompatible,

[OlegYch]

@julienrf hm actually it looks like current testkit is wrong endpoints4s/endpoints4s#1222 (the new test fails)

[OlegYch]

hm, maybe it's just a problem with pekko implementation, as http4s passes the new test

[OlegYch]

@julienrf i fixed pekko, can you please release new testkit?

[julienrf]

This looks good to me apart from a couple of minor comments, thank you @OlegYch!