Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creating BrowserDetector fails when located in vendor #38

Closed
mimmi20 opened this issue Jul 9, 2019 · 4 comments · Fixed by #39
Closed

creating BrowserDetector fails when located in vendor #38

mimmi20 opened this issue Jul 9, 2019 · 4 comments · Fixed by #39
Assignees
@serhiime
Labels
4.0 accepted bug

Comments

@mimmi20
Copy link

mimmi20 commented Jul 9, 2019 •
edited
Loading

If this project is an dependency of another project, creating a new BrowserDetector instance fails.

 PHP Fatal error:  Uncaught EndorphinStudio\Detector\Exception\StorageException: /home/developer/projects/useragent-parser-comparison/parsers/endorphin-php-4/vendor/endorphin-studio/browser-detector/vendor/endorphin-studio/browser-detector-data/var/yaml is not directory or not exists in /home/developer/projects/useragent-parser-comparison/parsers/endorphin-php-4/vendor/endorphin-studio/browser-detector-data/src/Storage/AbstractStorage.php:39
Stack trace:
#0 /home/developer/projects/useragent-parser-comparison/parsers/endorphin-php-4/vendor/endorphin-studio/browser-detector/src/Detector.php(87): EndorphinStudio\Detector\Storage\AbstractStorage->setDataDirectory('/home/developer...')
#1 /home/developer/projects/useragent-parser-comparison/parsers/endorphin-php-4/scripts/parse-ua.php(25): EndorphinStudio\Detector\Detector->__construct()
#2 {main}
  thrown in /home/developer/projects/useragent-parser-comparison/parsers/endorphin-php-4/vendor/endorphin-studio/browser-detector-data/src/Storage/AbstractStorage.php on line 39
@mimmi20 mimmi20 changed the title creating BrowserDetector fails when localed in vendor creating BrowserDetector fails when located in vendor Jul 9, 2019
@serhiime serhiime self-assigned this Jul 15, 2019
@serhiime
Copy link
Member

@mimmi20 Thanks for your submission. I will try to fix it asap

serhiime added a commit that referenced this issue Jul 15, 2019
@serhiime
GH-38 - GH-38 - creating BrowserDetector fails when located in vendor
a12b7cb 
- change detector initialization
- add options to constructor
- add reflection to find data dir
@serhiime serhiime mentioned this issue Jul 15, 2019
Merged
serhiime added a commit that referenced this issue Jul 15, 2019
@serhiime
GH-38 - GH-38 - creating BrowserDetector fails when located in vendor
884893c 
- fix copy paste
- fix duplicates
serhiime added a commit that referenced this issue Jul 15, 2019
@serhiime
GH-38 - GH-38 - creating BrowserDetector fails when located in vendor
1690c96 
- fix
serhiime added a commit that referenced this issue Jul 15, 2019
@serhiime
GH-38 - GH-38 - creating BrowserDetector fails when located in vendor
bf78b48 
- fix
serhiime added a commit that referenced this issue Jul 15, 2019
@serhiime
GH-38 - GH-38 - creating BrowserDetector fails when located in vendor
2169eb8 
- fix
serhiime added a commit that referenced this issue Jul 15, 2019
@serhiime
GH-38 - GH-38 - creating BrowserDetector fails when located in vendor
78937ba 
- fix testing
serhiime added a commit that referenced this issue Jul 15, 2019
@serhiime
GH-38 - GH-38 - creating BrowserDetector fails when located in vendor
65aa474 
- fix testing
serhiime added a commit that referenced this issue Jul 15, 2019
@serhiime
GH-38 - GH-38 - creating BrowserDetector fails when located in vendor
049d4cb 
- fix testing
serhiime added a commit that referenced this issue Jul 15, 2019
@serhiime
Merge pull request #39 from endorphin-studio/gh-38
d32c96e 
GH-38 - GH-38 - creating BrowserDetector fails when located in vendor
@serhiime
Copy link
Member

@mimmi20 Test it please. I think i fixed it at 4.0.3 version

@mimmi20
Copy link
Author

mimmi20 commented Jul 15, 2019

@serhiime It works now. Thanks

@serhiime
Copy link
Member

@mimmi20 You are welcome

@endorphin-studio endorphin-studio locked as resolved and limited conversation to collaborators Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@serhiime serhiime

Labels
4.0 accepted bug
Projects
None yet
Milestone
No milestone
2 participants
@mimmi20 @serhiime