Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE flip non trapping shim default #2699

Draft
wants to merge 1 commit into
base: markm-use-no-trapping-shim
Choose a base branch
from

Conversation

erights
Copy link
Contributor

@erights erights commented Jan 25, 2025

Staged on #2675

Closes: #XXXX
Refs: #XXXX

Description

Flips the non-trapping shim to default 'enabled', requiring opt-out to be explicit.

This is not intended for production, but rather only to test in CI that everything else is compat with the opted in setting.

Security Considerations

Does this change introduce new assumptions or dependencies that, if violated, could introduce security vulnerabilities? How does this PR change the boundaries between mutually-suspicious components? What new authorities are introduced by this change, perhaps by new API calls?

Scaling Considerations

Does this change require or encourage significant increase in consumption of CPU cycles, RAM, on-chain storage, message exchanges, or other scarce resources? If so, can that be prevented or mitigated?

Documentation Considerations

Give our docs folks some hints about what needs to be described to downstream users. Backwards compatibility: what happens to existing data or deployments when this code is shipped? Do we need to instruct users to do something to upgrade their saved data? If there is no upgrade path possible, how bad will that be for users?

Testing Considerations

Every PR should of course come with tests of its own functionality. What additional tests are still needed beyond those unit tests? How does this affect CI, other test automation, or the testnet?

Compatibility Considerations

Does this change break any prior usage patterns? Does this change allow usage patterns to evolve?

Upgrade Considerations

What aspects of this PR are relevant to upgrading live production systems, and how should they be addressed?

Include *BREAKING*: in the commit message with migration instructions for any breaking change.

Update NEWS.md for user-facing changes.

Delete guidance from pull request description before merge (including this!)

@erights erights self-assigned this Jan 25, 2025
@erights erights changed the base branch from master to markm-use-no-trapping-shim January 25, 2025 22:11
@erights erights force-pushed the markm-use-no-trapping-shim branch from 0098db1 to a11fc2e Compare January 27, 2025 03:40
@erights erights changed the title Markm flip non trapping shim default DO NOT MERGE flip non trapping shim default Jan 27, 2025
@erights erights force-pushed the markm-flip-non-trapping-shim-default branch from eb96f7f to bd79cff Compare January 27, 2025 04:25
@erights erights force-pushed the markm-use-no-trapping-shim branch from a11fc2e to e40dcb3 Compare January 27, 2025 04:50
@erights erights force-pushed the markm-flip-non-trapping-shim-default branch from bd79cff to 19e38a7 Compare January 27, 2025 04:51
@erights erights force-pushed the markm-use-no-trapping-shim branch from e40dcb3 to 8173b85 Compare January 27, 2025 20:07
@erights erights force-pushed the markm-flip-non-trapping-shim-default branch from 19e38a7 to 83de018 Compare January 27, 2025 20:08
@erights erights force-pushed the markm-use-no-trapping-shim branch from 8173b85 to 8af0295 Compare February 7, 2025 00:42
@erights erights force-pushed the markm-flip-non-trapping-shim-default branch from 83de018 to 700dccf Compare February 7, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant