test: additional tests of splitRecord #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
approved these changes
Sep 14, 2023
Comment on lines
+333
to
+334
| successCase(specimen, M.splitRecord({}, undefined, undefined)); | ||
| successCase(specimen, M.splitRecord({}, { unused: M.string() })); |
There was a problem hiding this comment.
Whether it was a good or bad convention, I seem to have followed a convention of grouping success cases together, followed by fail cases. I don't feel strongly about this, but I'd prefer these success cases be moved up to be in the success case group.
There was a problem hiding this comment.
As a reader, whether something is a success or fail case is starkly apparent from the function call.
What's not so apparent is what tests are aspects of the same behavior. I've used the ordering here to group that and I think it's wortwhile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More test coverage of
M.splitRecord