fix: tolerate symbols as property names (#547)

* fix: tolerate symbols as property names
endojs · Dec 18, 2020 · f16bbc3 · f16bbc3
1 parent 85d2062
commit f16bbc3
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/ses/src/enable-property-overrides.js b/packages/ses/src/enable-property-overrides.js
@@ -89,7 +89,9 @@ export default function enablePropertyOverrides(intrinsics) {
       function setter(newValue) {
         if (obj === this) {
           throw new TypeError(
-            `Cannot assign to read only property '${prop}' of '${path}'`,
+            `Cannot assign to read only property '${String(
+              prop,
+            )}' of '${path}'`,
           );
         }
         if (objectHasOwnProperty(this, prop)) {
@@ -142,8 +144,10 @@ export default function enablePropertyOverrides(intrinsics) {
       }
 
       // Plan has no symbol keys and we use getOwnPropertyNames()
-      // to avoid issues with stringification of property name.
-      const subPath = `${path}.${prop}`;
+      // so `prop` cannot only be a string, not a symbol. We coerce it in place
+      // with `String(..)` anyway just as good hygiene, since these paths are just
+      // for diagnostic purposes.
+      const subPath = `${path}.${String(prop)}`;
       const subPlan = plan[prop];
 
       if (subPlan === true) {