Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: This PR implements enables CD builds on Pull Requests, so people can download and playtest PRs without having to compile.
Feature Details
With this change, the CD workflow will run,
In the case of 1), artifacts will be published to the
continuous
release. For PRs, artifacts can be downloaded from the "Checks" tab:https://gfycat.com/annualtintedcopepod
The download is still only available for logged-in users: actions/upload-artifact#51
Testing Done
Tested on a multitude of PRs. As far as i can tell, this change needs to be in the head branch, so this will not work for old PRs until they merge master.
Follow-up features:
Post a comment on the PR with links to the assets. Unfortunately, Github's Actions API is still somewhat immature, so this would require querying and parsing the Github API. There is a nice action for "Sticky" comments, though: https://github.com/marocchino/sticky-pull-request-comment