Mixtrack3: add option for Library navigation mode: Focus | Classic

[ronso0]

This adds controller preferences on top of mixxxdj#14180 to allow users to choose between the focus and classic library navigation.
I think the new behavior is a somewhat 'breaking change', and this is a good minimal example for controller preferences.

Please test if this works:
in the controller settings page there should now be an option for the Library navigation

What do you think?

[endcredits33]

Thanks for this. I've tested it and the new option does appear in the controller settings page but changing it doesn't seem to have any impact.

The default focus mode works as expected but after changing it to classic the behaviour remains the same.

[ronso0]

whoopsy.. fixed!
I mixed up label and value, see the diff https://github.com/endcredits33/mixxx/compare/c44e3fad5e3ebf4f5b5895b279a6425258e3c9de..722bb2cb54daef96c1356cd8dffa3b847b328202

[endcredits33]

Still not working correctly :( Completely uneducated guess but is it something to do with const libraryModes defining focus & classic as 0 and 1, respectively?

[ronso0]

const libraryModes defining focus & classic as 0 and 1, respectively?

No, const just means the array is filled once and can't be altered later on.
Same for const LibraryMode, it's set once from settings.

🤦‍♂️ after all it was a typo...
should now work as expected.

[endcredits33]

Ok so the switching between modes works now but the actual mode behaviour isn't quite right.

Focus mode works correctly if I change line 1094 to if (LibraryMode === libraryModes.focus) {

Classic mode still seems to rely on having the right element focused. It's not possible to expand anything in the sidebar with shift+press Browse if the focus is on the track table.

[ronso0]

Okay, good to know it's working.
I suggest you cherry-pick the commit, fix that part and squash that into my commit.

[ronso0]

Yes, 'Classic' mode is limited. Reason I proposed this setting in the first place is that it's useful for those who use Mixxx while having another window in the foreground (Mixxx doesn't have keyboard focus then and the 'new' controls don't apply)
See mixxxdj#11285 and mixxxdj#11285

Shift + press is used for maximizing the library, but it could as well be [Playlist],ToggleSelectedSidebarItem, that's the tradeoff. Another option? ; ) (just kidding..)

[endcredits33]

Not sure if I did everything correctly (first time using git) but I wasn't able to cherry-pick via the command line due to an error so I merged your commit and then made the fix in a separate commit #a5e443c479504b61a35c6bd544bf63e70feef595

Please let me know if this is incorrect in any way

[ronso0]

Sure, as long as it works.
Would be best to squash the commits in thebother PR before merge.

What was the error message?
Probably the commit was unknown, you need to add my Mixxx fork to your remote (like you added the Mixxx repo), then fetch so your git knows about all my commits.

[endcredits33]

That must be it, I didn't add your fork. It was a fatal error bad object message.