Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin uvloop to the lastest Python 3.6 supported version #952

Merged
merged 2 commits into from
Feb 10, 2021
Merged

fix: pin uvloop to the lastest Python 3.6 supported version #952

merged 2 commits into from
Feb 10, 2021

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Feb 10, 2021

Latest uvloop release (0.15.0) doesn't support Python 3.6 anymore. I don't know what decision uvicorn is going to take, but maybe before a deciison is made, we can pin uvloop 0.14.0.

Alternatives:

  • Uvicorn follows uvloop and stop supporting 3.6.

@euri10
Copy link
Member

euri10 commented Feb 10, 2021

could also use another pep508 environment-markers specifically for this line, something like, not sure this works

    "uvloop==0.14.0 ; python_version == '3.6'" + env_marker_cpython,
    "uvloop>=0.14.0 ;" + env_marker_cpython,

@Kludex
Copy link
Member Author

Kludex commented Feb 10, 2021

Sure, no problem!

Give me two minutes :)

EDIT: Going to take more time, cause it didn't work, and I need to check why (working time). 😗

@euri10
Copy link
Member

euri10 commented Feb 10, 2021

I may have forgot an and after the 3.6 !

Copy link
Member

@euri10 euri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Kludex

@euri10 euri10 merged commit bf7dac3 into encode:master Feb 10, 2021
@Kludex
Copy link
Member Author

Kludex commented Feb 10, 2021

Thank you! :)

Just for the record, I couldn't make it work without pinning the Python versions on both lines.

@euri10
Copy link
Member

euri10 commented Feb 10, 2021

hehe >) seems like we have another parisian contributor ! that begins to look like a mafia :)

@abduakhatov
Copy link

@euri10 @Kludex still not working when pulling from docker hub. how to get latest patches?

@euri10
Copy link
Member

euri10 commented Feb 16, 2021

@euri10 @Kludex still not working when pulling from docker hub. how to get latest patches?

I'm not sure where to start, this will be available through a release and you'll get it with pip install -U or something equivalent once the release is published, there's no link with docker

extra_requirements = [
"websockets==8.*",
"httptools==0.1.* ;" + env_marker_cpython,
"uvloop>=0.14.0 ;" + env_marker_cpython,
"uvloop==0.14.0; python_version == '3.6' and " + env_marker_cpython,
"uvloop>=0.14.0; python_version >= '3.7' and " + env_marker_cpython,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd set this to 0.15.1 as there are many important bug fixes in 0.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants