-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin uvloop to the lastest Python 3.6 supported version #952
Conversation
could also use another pep508 environment-markers specifically for this line, something like, not sure this works
|
Sure, no problem! Give me two minutes :) EDIT: Going to take more time, cause it didn't work, and I need to check why (working time). 😗 |
I may have forgot an and after the 3.6 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Kludex
Thank you! :) Just for the record, I couldn't make it work without pinning the Python versions on both lines. |
hehe >) seems like we have another parisian contributor ! that begins to look like a mafia :) |
extra_requirements = [ | ||
"websockets==8.*", | ||
"httptools==0.1.* ;" + env_marker_cpython, | ||
"uvloop>=0.14.0 ;" + env_marker_cpython, | ||
"uvloop==0.14.0; python_version == '3.6' and " + env_marker_cpython, | ||
"uvloop>=0.14.0; python_version >= '3.7' and " + env_marker_cpython, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd set this to 0.15.1 as there are many important bug fixes in 0.15.
Latest uvloop release (0.15.0) doesn't support Python 3.6 anymore. I don't know what decision
uvicorn
is going to take, but maybe before a deciison is made, we can pin uvloop 0.14.0.Alternatives: