Tweak detection of app factories #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
569cce9 to
0cba6ca
Compare
0cba6ca to
d4c0060
Compare
euri10
approved these changes
Dec 26, 2020
|
this rocks ! |
|
Great, thanks! |
Merged
ion-oset
added a commit
to ion-oset/electorate-vanadium-core
that referenced
this pull request
Jan 13, 2022
- Add help for 'make serve-test', clarifying that it enables reloads.
- Add '--factory' flag to silence warning:
ASGI app factory detected. Using it, but please consider setting the --factory flag explicitly.
See:
- https://www.uvicorn.org/#application-factories
- encode/uvicorn#875
- encode/uvicorn#914
ion-oset
added a commit
to TrustTheVote-Project/Electorate-Vanadium-Core
that referenced
this pull request
Feb 8, 2022
- Add help for 'make serve-test', clarifying that it enables reloads.
- Add '--factory' flag to silence warning:
ASGI app factory detected. Using it, but please consider setting the --factory flag explicitly.
See:
- https://www.uvicorn.org/#application-factories
- encode/uvicorn#875
- encode/uvicorn#914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #900, cleanup for #875, based on #900 (comment)
Instead of inspecting the
app, attempt to call it without arguments each time.--factory, consider it as normal — the app is meant to be an app instance.--factory, exit with an error message — the factory failed to load.--factory, keep Uvicorn running, but issue a warning — explicit flag is preferred:This removes the
inspect.signaturecode that was causing getsentry/sentry-python#947.