Fix reload process behavior when exception is raised #1313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current master (and latest version [0.16.0]) makes the
--reload
command to not work as expected.Considering a simple application:
When running
uvicorn main:app --reload
when the code above, and removing one of the lines with...
, the reload process will exit. We don't want that. #1115 was not true for--reload
.The output for it can be seen below (after that, the process exits):
The changes proposed here makes the reload process to work as expected i.e. reload the uvicorn server, and not exit when modifications that are not able to run are made.