Allow Click 8.0, refs #1016 #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonw
commented
May 23, 2021
| @@ -44,7 +44,7 @@ def get_packages(package): | |||
| env_marker_below_38 = "python_version < '3.8'" | |||
|
|
|||
| minimal_requirements = [ | |||
| "click==7.*", | |||
| "click>=7.*", | |||
There was a problem hiding this comment.
I wonder if this should also specify <9 to avoid an accidental upgrade to Click 9.0 some time in the future.
euri10
approved these changes
May 23, 2021
This was referenced May 27, 2021
br3ndonland
added a commit
to br3ndonland/inboard
that referenced
this pull request
Jul 5, 2021
https://github.com/encode/uvicorn/releases/tag/0.14.0 https://click.palletsprojects.com/en/8.0.x/changes/ Uvicorn now allows Click 8 to be used (encode/uvicorn#1042), which is notable because of a security fix added in Click 8. This fix patches an insecure temporary file vulnerability, and was reported by CodeQL scans in the inboard repo. The Click maintainers did not clearly report this vulnerability in the release notes. The release notes entry merely says, "Use `mkstemp()` instead of `mktemp()` in pager implementation." The fix provided in pallets/click#1754 does not explain the implications of the change. The issue report in pallets/click#1752 was criticized for not respecting https://github.com/pallets/click/security/policy, but Click did not provide adequate information otherwise.
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1033 but updates the CLI documentation to reflect new whitespace.