Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uvicorn ignores --uds for --reload #586

Closed
Roang-zero1 opened this issue Mar 9, 2020 · 1 comment
Closed

Uvicorn ignores --uds for --reload #586

Roang-zero1 opened this issue Mar 9, 2020 · 1 comment

Comments

@Roang-zero1
Copy link
Contributor

As talked about in #368 the --reload setting ignores the --uds setting, thereby reload binds itself to the default localhost:8000.

In our dev deployment we try to stay as close to production as possible. Due to this issue we have to workaround our nginx config to fall back to a https socket in dev,

I would like to request this feature to be added.
@tomchristie
Copy link
Member

Personally I'm going to treat this as out of scope at the moment. If someone wants to take a go at a PR for it, I'd happily review it, but otherwise there's no realistic chance of me being able to make time for it.

For now --reload is a development setting that shouldn't be used alongside --uds which is for use with in production.

Professional Tier Sponsors are able to request priority support... https://github.com/sponsors/encode

jcwilson pushed a commit to jcwilson/uvicorn that referenced this issue Aug 27, 2020
Update --reload docs to clarify when it can be used
eb09a84 
The `--reload` option is incompatible with the `--uds` and `--fd` options. This can be surprising
to developers that are trying to replicate production deployment settings in their development
environment.

This simply adds some notes to the deployment documentation to let people know about this ahead of
time.

See encode#368 and encode#586.
@jcwilson jcwilson mentioned this issue Aug 27, 2020
Open
@Roang-zero1 Roang-zero1 mentioned this issue Sep 29, 2020
Closed
@euri10 euri10 mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomchristie @Roang-zero1