Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testclient test for domain restricted cookies #2154

Merged
merged 4 commits into from
May 31, 2023

Conversation

nidico
Copy link
Contributor

@nidico nidico commented May 24, 2023

Summary

This adds a test for #2152 which creates responses with domain restricted cookies for different domains.

The test with the testserver domain parametrization succeeds in Python 3.11 but fails on Python 3.10 and below.

Note that this PR just adds a partially failing test, but doesn't resolve #2152 (e.g. by changing documentation or changing the test client default base_url).

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

This adds a test for encode#2152 which creates responses with domain
restricted cookies for different domains.

The test with the `testserver` domain parametrization succeeds in Python
3.11 but fails on Python 3.10 and below.
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this for the time being. I understand that the problem is not solved, but at least documented on the test.

Let's see if we can solve it as a next step.

Thanks @nidico :)

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@Kludex Kludex merged commit bdabbf7 into encode:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testclient doesn't accept cookies with domain "testserver" in Python < 3.11
2 participants