Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: secure cookie middleware #2144

Merged
merged 1 commit into from
May 10, 2023
Merged

add: secure cookie middleware #2144

merged 1 commit into from
May 10, 2023

Conversation

thearchitector
Copy link
Contributor

Summary

Add https://github.com/thearchitector/starlette-securecookies as another third party middleware.

Not sure what the exact process is for adding to / updating the docs, so let me know if something else is required!

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to rewrite it to be a pure ASGI middleware: https://www.starlette.io/middleware/#pure-asgi-middleware

@adriangb adriangb merged commit 24c1fac into encode:master May 10, 2023
@thearchitector
Copy link
Contributor Author

It's already on the todo list, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants