Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types in lifespan examples #2123

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix types in lifespan examples #2123

merged 1 commit into from
Apr 17, 2023

Conversation

alex-oleshkevich
Copy link
Member

@alex-oleshkevich alex-oleshkevich commented Apr 14, 2023 •
edited
Loading

This makes lifespan examples to pass mypy checks.

@alex-oleshkevich
Copy link
Member Author

Initially I was misled by async def lifespan return type.

@Kludex Kludex merged commit ab296fd into encode:master Apr 17, 2023
@alex-oleshkevich alex-oleshkevich deleted the improve-types-in-docs branch April 17, 2023 11:45
adriangb pushed a commit to adriangb/starlette that referenced this pull request Apr 29, 2023
@alex-oleshkevich @adriangb
Fix types in lifespan examples (encode#2123)
7bf4f7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alex-oleshkevich @adriangb @Kludex